Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Analytics] Consolidate Analytics and AnalyticsSwift #11959

Merged
merged 3 commits into from
Oct 18, 2023
Merged

[Analytics] Consolidate Analytics and AnalyticsSwift #11959

merged 3 commits into from
Oct 18, 2023

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Oct 18, 2023 •
edited
Loading

Context

  • The contents of Analytics's Swift extension SDK has been moved into the main Analytics module, and the Analytics Swift extension SDK now re-exports the API that used to live in it.
  • This change should be non-breaking.

Tasks

  • The affected extension podspecs should be versioned to pin to the releasing version.
  • Update Analytics release notes with: 
    - [feature] The `FirebaseAnalytics` module now contains Firebase Analytics's
   Swift-only APIs that were previously only available via the
  `FirebaseAnalyticsSwift` extension SDK. See the
  `FirebaseAnalyticsSwift` release note from this release for more details.
  • When this PR is merged, stage the affected podspecs and notify the Games team.

Important

@ncooke3 ncooke3 added this to the 10.17.0 - M139 milestone Oct 18, 2023
paulb777
paulb777 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on green

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023 •
edited
Loading

Apple API Diff Report

Commit: 7b04234
Last updated: Tue Oct 17 21:26 PDT 2023
View workflow logs & download artifacts

FirebaseAnalyticsSwift

[REMOVED] Extensions 
Swift:
-    public extension View
-      func analyticsScreen ( name : String , class : String = "View" , extraParameters : [ String : Any ] = [:]) -> some View

@ncooke3 ncooke3 merged commit 1883c2b into analytics-10.17.0 Oct 18, 2023
54 checks passed
@ncooke3 ncooke3 deleted the analytics-swift-merged branch October 18, 2023 12:19
@ncooke3
Copy link
Member Author

ncooke3 commented Oct 18, 2023

I merged on green CI. Will now wait for #11958 to finish testing. I can address any follow-up feedback there.

@firebase firebase locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: analytics public-api-change release-tooling
Projects
None yet
Milestone
10.17.0 - M139
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @paulb777 @google-oss-bot